Implement new SimpleSigstoreSigner and update exceptions in Signer #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiranSatyaRaj
force-pushed
the
new-SimpleSigstoreSigner
branch
from
a795f08 to
4b8c3e3
Compare
Signed-off-by: KiranSatyaRaj <[email protected]>
KiranSatyaRaj
force-pushed
the
new-SimpleSigstoreSigner
branch
from
4b8c3e3 to
421c4e6
Compare
| Object subAltArr = certificate.getSubjectAlternativeNames().toArray()[0]; | ||
| String subAltName = subAltArr.toString(); | ||
| subAltName = subAltName.substring(4, subAltName.length() - 1); | ||
| this.keyId = keyId.concat(" " + subAltName); |
There was a problem hiding this comment.
can you compute the keyid such as:
<oidc provider>:<SAN> ? this way we can also know who actually provided the identity to fulcio
There was a problem hiding this comment.
Is this how it's supposed to look?
<https://accounts.example.com>: <[email protected]>
@SantiagoTorres
Signed-off-by: KiranSatyaRaj <[email protected]>
Signed-off-by: KiranSatyaRaj <[email protected]>
Use Message Signature from Bundle to retrieve payload Digest Signed-off-by: KiranSatyaRaj <[email protected]>
Signed-off-by: KiranSatyaRaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for KeylessSigning the payload in dsse and updates the throwable exceptions in Signer